make sure Domain.fromDict(domain) doesn't change its input domain #5794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wochinge
reviewed
May 11, 2020
There was a problem hiding this comment.
Thanks for also applying the fix here!
- I think this should go in the
1.10.xbranch. - Also, it would be great to add a test which makes sure that
from_dictdoes not change the input dictionary. - can you link the Rasa X PR / issue where we fixed in this PR so that we have the connection?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes:
Previously, in
rasa.core.domain.Domain.fromDictandDomain.__init__could alter their inputs because of the wayDomain.collect_slotsandDomain.collect_intent_propertieswere implemented.This PR makes sure these
collectfunctions don't alter their inputs.This is related to https://github.com/RasaHQ/rasa-x/pull/2669, which fixes an issue in Rasa X that was caused by such a domain dictionary alteration.
Status (please check what you already did):
black(please check Readme for instructions)