-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Webex Channel Fix: personId -> roomId #6078
Conversation
This is a much needed fix because presently we are unable to have the rasa-bot respond back to the specific room that sends the message thus enabling `no reply` to the user The fix is also presented at RasaHQ#5460 but since it will be released at 1.11.0 thenn we need to hotfix it soon. References RasaHQ#5460
@wochinge kindly help for this MR. |
Thanks for submitting a pull request 🚀 @wochinge will take a look at it as soon as possible ✨ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for porting this @isaac-philip 🙏
Could you please add a short changelog entry?
Added the changelog, thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot! 🎉
Thanks for the help @wochinge ! 🥇 |
@wochinge do you have any document you can share on the release strategy employed? I would like to learn from it. |
@isaac-philip Thanks for your question! We talked about your question internally, and we fully agree with you that the release process should be documented publicly and transparently. We will keep track of our progress towards this in #6260 . Maybe this short info can help you out until #6260 is done:
|
This is a much needed fix because presently we are unable to have the rasa-bot respond back to the specific room that sends the message thus enabling
no reply
to the userThe fix is also presented at #5460 but since it will be released at 1.11.0 thenn we need to hotfix it soon.
References #5460
Proposed changes:
Status (please check what you already did):
black
(please check Readme for instructions)