Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for messages with non-standard characters #6150

Closed
chkoss opened this issue Jul 7, 2020 · 0 comments · Fixed by #6149
Closed

Add tests for messages with non-standard characters #6150

chkoss opened this issue Jul 7, 2020 · 0 comments · Fixed by #6149
Labels
area:rasa-oss 🎡 Anything related to the open source Rasa framework type:maintenance 🔧 Improvements to tooling, testing, deployments, infrastructure, code style.

Comments

@chkoss
Copy link
Contributor

chkoss commented Jul 7, 2020

Description of Problem:

Currently, there are not enough tests for processing of messages / training examples with a wide range of non-standard characters. Bug with processing such messages can go unnoticed when releasing a new Rasa Open Source version, and will only be caught when trying to release a new Rasa X version. They will then also block the Rasa X release (as happened with Rasa X 0.30.0).

Overview of the Solution:

Add proper emoji testing to Rasa Open Source (e.g. similar to the integration tests in Rasa X here and here). A good list to test on can be found here: https://github.com/minimaxir/big-list-of-naughty-strings/blob/master/blns.json

@chkoss chkoss added type:maintenance 🔧 Improvements to tooling, testing, deployments, infrastructure, code style. area:rasa-oss 🎡 Anything related to the open source Rasa framework labels Jul 7, 2020
@chkoss chkoss linked a pull request Jul 7, 2020 that will close this issue
4 tasks
@m-vdb m-vdb closed this as completed Sep 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:rasa-oss 🎡 Anything related to the open source Rasa framework type:maintenance 🔧 Improvements to tooling, testing, deployments, infrastructure, code style.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants