Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock Failure Not Reported #6226

Closed
rgstephens opened this issue Jul 16, 2020 · 2 comments
Closed

Lock Failure Not Reported #6226

rgstephens opened this issue Jul 16, 2020 · 2 comments
Assignees
Labels
area:rasa-oss 🎡 Anything related to the open source Rasa framework type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR

Comments

@rgstephens
Copy link
Contributor

Description of Problem:
When hitting the REST endpoint with an utterance, we received no response. After that the REST endpoint stopped responding to requests. There were no messages related to the endpoint call - no indication that the user has sent an utterance. This made for difficult troubleshooting. Eventually figured out that there was an issue with a custom (clustered Redis) lock store.

Overview of the Solution:
The lock store code needs to add debug logging and report this type of error.

@rgstephens rgstephens added type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR area:rasa-oss 🎡 Anything related to the open source Rasa framework labels Jul 16, 2020
@wochinge
Copy link
Contributor

more information in here: https://github.com/RasaHQ/rasa-x/issues/2079

@wochinge
Copy link
Contributor

Debugging / Ideation

  • in get_lock redis.get(...) blocks indefinitely
    • setting socket_timeout on the redis client helps

How to reproduce:

  • run redis: docker run -p 6379:6379 redis
  • use the following lock store config
lock_store:
    type: "redis"
    url: localhost
    port: 6379
    db: 0
    use_ssl: True. # using ssl if redis isn't configured so, will block. Set to `False` to make it working

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:rasa-oss 🎡 Anything related to the open source Rasa framework type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR
Projects
None yet
Development

No branches or pull requests

2 participants