Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix responses being added to actions #6255

Merged
merged 4 commits into from
Jul 29, 2020
Merged

fix responses being added to actions #6255

merged 4 commits into from
Jul 29, 2020

Conversation

wochinge
Copy link
Contributor

@wochinge wochinge commented Jul 21, 2020 •
edited
Loading

Proposed changes:

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@wochinge wochinge requested a review from alwx July 21, 2020 16:16
@wochinge wochinge force-pushed the fix-responses-to-utterances branch from f49ef99 to cd1a765 Compare July 21, 2020 16:20
@wochinge wochinge changed the title fix responses being added to utterances fix responses being added to actions Jul 22, 2020
@chkoss chkoss linked an issue Jul 27, 2020 that may be closed by this pull request
don't add responses to actions section of domain file #6033
Closed
@ricwo ricwo removed the request for review from alwx July 29, 2020 07:42
ricwo
ricwo approved these changes Jul 29, 2020
View reviewed changes
Copy link
Contributor

@ricwo ricwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 👍

changelog/6255.improvement.rst Outdated Show resolved Hide resolved
changelog/6255.improvement.rst Outdated Show resolved Hide resolved
@rasabot rasabot merged commit 280b125 into 1.10.x Jul 29, 2020
@rasabot rasabot deleted the fix-responses-to-utterances branch July 29, 2020 11:25
@wochinge
Copy link
Contributor Author

wochinge commented Aug 3, 2020

Thanks @ricwo 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ricwo ricwo ricwo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

don't add responses to actions section of domain file
3 participants
@wochinge @ricwo @rasabot