-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass message metadata to interpreter when parsing #6275
Conversation
Thanks for submitting a pull request 🚀 @tttthomasssss will take a look at it as soon as possible ✨ |
@federicotdn Would you mind having a look at this one? 🙏 |
Hey @pheel, could you share a bit more context on why you need the metadata for |
@federicotdn Exactly right! this is for a custom class, which makes use of contextual metadata sent over a socket to guide interpretation. Right now an incoming message |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok! Looks good. You you mind merging master into it? I think there might be some merge conflicts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Proposed changes:
Status (please check what you already did):
black
(please check Readme for instructions)