Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configurable prefixes to Redis Tracker and Lock stores #6498

Closed
bjbredis opened this issue Aug 27, 2020 · 2 comments
Closed

Add configurable prefixes to Redis Tracker and Lock stores #6498

bjbredis opened this issue Aug 27, 2020 · 2 comments
Labels
area:rasa-oss 🎡 Anything related to the open source Rasa framework type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR

Comments

@bjbredis
Copy link
Contributor

Description of Problem:
Currently Rasa does not allow using the same Redis instance for the TrackerStore and the LockStore because they use the same keys which overwrite each other or Rasa requires separate logical Redis DBs which most Redis services do not support multiple logical DBs (only select 0 supported).
Related issues:

Overview of the Solution:
Allow a new parameter in endpoints.yml to specify an alphanumeric prefix which is prepended to all keys for the given (Lock|Tracker)Store. The prefix should be optional for compatibility therefore the configurable prefix will be prepended as either prefix:lock:<senderid or prefix:tracker:<senderid>. The lock and tracker keys will not collide and a given Redis instance can be used by more than one conversation tracker.

Definition of Done:

  • [y] Tests are added Existing tests provide sufficient coverage with minor changes.
  • [y] Feature described the docs
  • [y] Feature mentioned in the changlog
@bjbredis bjbredis added area:rasa-oss 🎡 Anything related to the open source Rasa framework type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR labels Aug 27, 2020
@sara-tagger
Copy link
Collaborator

Thanks for submitting this feature request 🚀 @koaning will get back to you about it soon! ✨

@alwx
Copy link
Contributor

alwx commented Jan 29, 2021

Closing because the PR is merged.

@alwx alwx closed this as completed Jan 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:rasa-oss 🎡 Anything related to the open source Rasa framework type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR
Projects
None yet
Development

No branches or pull requests

3 participants