Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rasa spliting algorithm does not give precise number of training samples. #6582

Closed
duongkstn opened this issue Sep 7, 2020 · 2 comments · Fixed by #7095
Closed

Rasa spliting algorithm does not give precise number of training samples. #6582

duongkstn opened this issue Sep 7, 2020 · 2 comments · Fixed by #7095
Assignees
@alopez
Labels
area:rasa-oss 🎡 Anything related to the open source Rasa framework type:bug 🐛 Inconsistencies or issues which will cause an issue or problem for users or implementors.

Comments

@duongkstn
Copy link

duongkstn commented Sep 7, 2020 •
edited
Loading

Description of Problem: Some examples may be missed due to Rasa spliting algorithm.The issues is clearly depicted at forum thread

Overview of the Solution: rasa data split does not give precise number of training samples.
Say overall we have X samples (x1 samples of label l1, x2 samples of label l2, …) and training-fraction is 0.8.
(Note: x1 + x2 + … = X).
In the code of Rasa , number of training samples is A = int(0.8 * x1) + int(0.8 * x2) + …
Mathematically, A ≤ int(0.8 * X).
So number of missing samples is int(0.8 * X) - A
@duongkstn duongkstn added area:rasa-oss 🎡 Anything related to the open source Rasa framework type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR labels Sep 7, 2020
@sara-tagger
Copy link
Collaborator

Thanks for submitting this feature request 🚀 @JustinaPetr will get back to you about it soon! ✨

@Ghostvv Ghostvv added type:bug 🐛 Inconsistencies or issues which will cause an issue or problem for users or implementors. and removed type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR labels Sep 7, 2020
@alopez alopez mentioned this issue Oct 9, 2020
Closed
4 tasks
@alopez alopez mentioned this issue Oct 23, 2020
Merged
4 tasks
@alopez alopez linked a pull request Oct 29, 2020 that will close this issue
Fixes a bug with rasa data split nlu #7095
Merged
4 tasks
@tabergma
Copy link
Contributor

tabergma commented Nov 2, 2020

closed via #7095

@tabergma tabergma closed this as completed Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alopez alopez

Labels
area:rasa-oss 🎡 Anything related to the open source Rasa framework type:bug 🐛 Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes a bug with rasa data split nlu RasaHQ/rasa
5 participants
@alopez @Ghostvv @tabergma @duongkstn @sara-tagger