Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Lock Store + Multiple Sanic Workers #6629

Closed
joeriess opened this issue Sep 10, 2020 · 4 comments
Closed

Custom Lock Store + Multiple Sanic Workers #6629

joeriess opened this issue Sep 10, 2020 · 4 comments
Labels
area:rasa-oss 🎡 Anything related to the open source Rasa framework type:bug 🐛 Inconsistencies or issues which will cause an issue or problem for users or implementors.

Comments

@joeriess
Copy link
Contributor

Rasa version: 1.10.3

Rasa SDK version (if used & relevant):

Rasa X version (if used & relevant):

Python version: 3.7

Operating system (windows, osx, ...): macOS

Issue:

In our application we use a custom lock store since we are using a cloud based Redis instance that communicates over TLS. When trying to run multiple Sanic workers we receive this warning:

Unable to assign desired number of Sanic workers 4 as no `RedisLockStore` endpoint configuration has been found.

Digging deeper I see there is a check to ensure the lock store type is 'redis'.

Can we update the logic so it is something like this?:

return lock_store is not None and lock_store.type != "in_memory"

Thank you in advance!

@joeriess joeriess added area:rasa-oss 🎡 Anything related to the open source Rasa framework type:bug 🐛 Inconsistencies or issues which will cause an issue or problem for users or implementors. labels Sep 10, 2020
@sara-tagger
Copy link
Collaborator

Thanks for raising this issue, @tabergma will get back to you about it soon✨

Please also check out the docs and the forum in case your issue was raised there too 🤗

@tabergma
Copy link
Contributor

@ricwo Can you please have a look. Thanks.

@ricwo
Copy link
Contributor

ricwo commented Sep 11, 2020

@joeriess thanks for raising this issue. I agree with your suggestion, multiple sanic workers should be safe to use with an in-memory tracker store as well. do you want to create a PR for that?

@akelad
Copy link
Contributor

akelad commented Nov 19, 2020

@akelad akelad closed this as completed Nov 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:rasa-oss 🎡 Anything related to the open source Rasa framework type:bug 🐛 Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Development

No branches or pull requests

5 participants