Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bugfix][WIP] Fix the bug of language supporting detection function of component #6803

Merged
merged 66 commits into from
Oct 7, 2020
Merged

[bugfix][WIP] Fix the bug of language supporting detection function of component #6803

merged 66 commits into from
Oct 7, 2020

Conversation

howl-anderson
Copy link
Contributor

Proposed changes:

  • supported_langauge_list and not_supported_language_list are not allowed be setted in same time.
  • update the implement of can_handle_language function

fix #6802

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@howl-anderson howl-anderson mentioned this pull request Sep 27, 2020
Closed
4 tasks
@sara-tagger
Copy link
Collaborator

Thanks for submitting a pull request 🚀 @dakshvar22 will take a look at it as soon as possible ✨

dakshvar22
dakshvar22 requested changes Oct 2, 2020
View reviewed changes
Copy link
Contributor

@dakshvar22 dakshvar22 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for trying to fix this! 🚀
Left a couple of copy edit suggestions and requested a change in the logic at one place.
Also, can you please add a test for this so that it doesn't fail in future?

changelog/6803.bugfix.md Outdated Show resolved Hide resolved
rasa/nlu/components.py Outdated Show resolved Hide resolved
rasa/nlu/components.py Outdated Show resolved Hide resolved
rasa/nlu/components.py Outdated Show resolved Hide resolved
akelad and others added 22 commits October 5, 2020 15:40
@akelad
add the variables import back in
5b994d5
@rasabot
Merge branch 'master' into add-variables
a4146e4
@degiz
Merge branch 'master' into 6867_md_test_stories
60c21a7
@m-vdb
support sophisticated code blocks
deaa733
@rasabot
Merge branch 'master' into 6867_md_test_stories
ca55c4e
@rasabot
Merge branch 'master' into add-variables
65bffcd
@degiz
Merge branch 'master' into 6867_md_test_stories
e123345
@rasabot
Merge branch 'master' into 6867_md_test_stories
bd18a63
@rasabot
Merge branch 'master' into add-variables
daeade9
@rasabot
Merge branch 'master' into 6867_md_test_stories
916e618
@rasabot
Merge branch 'master' into add-variables
e71e6df
@rasabot
Merge branch 'master' into 6867_md_test_stories
1bcfbe3
@rasabot
Merge branch 'master' into add-variables
eb88404
@rasabot
Merge pull request RasaHQ#6890 from RasaHQ/6867_md_test_stories
395dd0f 
Fixed bug with conversion of MD test stories
@rasabot
Merge branch 'master' into add-variables
7ead70c
@rasabot
Merge branch 'master' into add-variables
838da9e
@howl-anderson
Merge branch 'master' of https://github.com/RasaHQ/rasa into bugfix/c…
b6e05a6 
…omponent_language_support
@howl-anderson
Improve description text in changelog
c5aacaa
@howl-anderson
Improve description comment in Component
bdb9ece
@howl-anderson
Add guard clause for unavailable settings
d432a67
@howl-anderson
reformat the code
4cdc3d4
@howl-anderson
add test cases
13937d9
@dakshvar22 dakshvar22 changed the base branch from master to 2.0.x October 6, 2020 10:06
@dakshvar22 dakshvar22 changed the base branch from 2.0.x to master October 6, 2020 10:07
@howl-anderson
Copy link
Contributor Author

Hi @dakshvar22, I just rebase the PR to 2.0.x, it should works now.

@dakshvar22 dakshvar22 changed the base branch from master to 2.0.x October 6, 2020 10:20
@dakshvar22 dakshvar22 self-requested a review October 6, 2020 11:24
dakshvar22
dakshvar22 reviewed Oct 6, 2020
View reviewed changes
changelog/6803.bugfix.md Outdated Show resolved Hide resolved
dakshvar22
dakshvar22 approved these changes Oct 6, 2020
View reviewed changes
Copy link
Contributor

@dakshvar22 dakshvar22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@dakshvar22 dakshvar22 merged commit d038571 into RasaHQ:2.0.x Oct 7, 2020
@howl-anderson howl-anderson mentioned this pull request Oct 7, 2020
Closed
@howl-anderson
Copy link
Contributor Author

@dakshvar22 Can I merge this PR into the master branch, so I can merge this bugfix into PR #6753 which relay on this.

@howl-anderson
Copy link
Contributor Author

@dakshvar22 I just read that the 2.0.x was merged into master a few hours ago though commit fe33091, sorry for the previous message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dakshvar22 dakshvar22 dakshvar22 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

A bug with language supporting detection function of component
8 participants
@howl-anderson @sara-tagger @dakshvar22 @m-vdb @erohmensing @akelad @rasabot @degiz