-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update markdown example to yml #6823
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks for taking these changes over 💯
I left a couple of comments. Additionally, could you update other text/markdown
content in this rasa.yml
file? I think that the spec for /model/test/intents
and /model/test/stories
can be updated, as they now accept yml request bodies (and this is the default now).
@yennycheung about that, it might be a bit more complicated than that. Since things are still a bit WIP on the API spec, I think it's better to put that on @lunelson 's radar so that he knows about it (he is in charge about our docs theme, among other things) |
Yeah I agree with you, I was just taking a look at the theme. I'll focus on the markdown changes then. :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
almost there 💪 only one example to change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🐩
@yennycheung @m-vdb this CSS conflict is on my radar, it will be fixed this week. |
Proposed changes:
Note for reviewer:
To do:
Looks like there are some css issues as well, the example has a white background, I might fix it while I'm at it.
Status (please check what you already did):
black
(please check Readme for instructions)