Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update markdown example to yml #6823

Merged
merged 9 commits into from
Sep 30, 2020
Merged

Update markdown example to yml #6823

merged 9 commits into from
Sep 30, 2020

Conversation

yennycheung
Copy link
Contributor

@yennycheung yennycheung commented Sep 28, 2020

Proposed changes:

Note for reviewer:

To do:

  • There are other examples with markdown, after I get the first feedback I'll update those too.
  • Looks like there are some css issues as well, the example has a white background, I might fix it while I'm at it.
    image

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@yennycheung yennycheung added type:docs 📖 Improvements to the documenation. Adding missing pieces or improving existing ones. area:rasa-oss 🎡 Anything related to the open source Rasa framework labels Sep 28, 2020
@yennycheung yennycheung added this to the 2.0 Rasa Open Source milestone Sep 28, 2020
@yennycheung yennycheung self-assigned this Sep 28, 2020
@CLAassistant
Copy link

CLAassistant commented Sep 28, 2020

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@m-vdb m-vdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for taking these changes over 💯

I left a couple of comments. Additionally, could you update other text/markdown content in this rasa.yml file? I think that the spec for /model/test/intents and /model/test/stories can be updated, as they now accept yml request bodies (and this is the default now).

docs/static/spec/rasa.yml Outdated Show resolved Hide resolved
docs/static/spec/rasa.yml Outdated Show resolved Hide resolved
docs/static/spec/rasa.yml Outdated Show resolved Hide resolved
@m-vdb m-vdb marked this pull request as ready for review September 29, 2020 06:47
@m-vdb
Copy link
Collaborator

m-vdb commented Sep 29, 2020

Looks like there are some css issues as well, the example has a white background, I might fix it while I'm at it.

@yennycheung about that, it might be a bit more complicated than that. Since things are still a bit WIP on the API spec, I think it's better to put that on @lunelson 's radar so that he knows about it (he is in charge about our docs theme, among other things)

@yennycheung
Copy link
Contributor Author

yennycheung commented Sep 29, 2020

Looks like there are some css issues as well, the example has a white background, I might fix it while I'm at it.

@yennycheung about that, it might be a bit more complicated than that. Since things are still a bit WIP on the API spec, I think it's better to put that on @lunelson 's radar so that he knows about it (he is in charge about our docs theme, among other things)

Yeah I agree with you, I was just taking a look at the theme. I'll focus on the markdown changes then. :)

Copy link
Collaborator

@m-vdb m-vdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

almost there 💪 only one example to change

docs/static/spec/rasa.yml Outdated Show resolved Hide resolved
Copy link
Collaborator

@m-vdb m-vdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐩

@lunelson
Copy link
Contributor

@yennycheung @m-vdb this CSS conflict is on my radar, it will be fixed this week.

@rasabot rasabot merged commit 92c16c7 into master Sep 30, 2020
@rasabot rasabot deleted the docs_issue-6762 branch September 30, 2020 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:rasa-oss 🎡 Anything related to the open source Rasa framework type:docs 📖 Improvements to the documenation. Adding missing pieces or improving existing ones.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants