-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve exception reporting for CLI commands #6856
Conversation
…exception-improvements
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 🚀 🚀 Amazing, thanks for doing these changes. I definitely think that they will improve the UX
thanks a lot for the quick review super helpful to get this merged in time ⭐ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great 💯 I think it's mergeable once the tests go green 🟢
Motivation:
Before:
After:
Proposed changes:
RasaOpenSourceException
RasaOpenSourceExceptions
will be caught if thrown as part of a CLI command and stack traces will not be printed by default, instead we useprint_error
NameError
exception raised when an action can not be found to be aValueError
insteadInvalidYAMLFileException
instead ofYAMLError
(from ruamel) when failing to load a yaml fileInvalidDomain
aRasaOpenSourceException
MissingDependencyException
as an exception raised if packages need to be installedrasa shell nlu
commandRasaOpenSourceException
s are ignored by sentryTODO
InvalidRule
is very user-unfriendly and vague, but out of this PRs scopeStatus (please check what you already did):
black
(please check Readme for instructions)