Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn for invalid keys for classifiers #6966

Closed
indam23 opened this issue Oct 8, 2020 · 10 comments · Fixed by #7134
Closed

Warn for invalid keys for classifiers #6966

indam23 opened this issue Oct 8, 2020 · 10 comments · Fixed by #7134
Assignees
Labels
area:rasa-oss 🎡 Anything related to the open source Rasa framework type:bug 🐛 Inconsistencies or issues which will cause an issue or problem for users or implementors.

Comments

@indam23
Copy link
Contributor

indam23 commented Oct 8, 2020

Rasa version: 2.0.0

Issue:

If you pass an invalid key to a classifier no warning or error is thrown during training

Command or request that led to lack of error:

rasa train

Content of configuration file (config.yml) (if relevant):

pipeline
- name: FallbackClassifier
   confidence_threshold: 0.7

(should be threshold)

@indam23 indam23 added type:bug 🐛 Inconsistencies or issues which will cause an issue or problem for users or implementors. area:rasa-oss 🎡 Anything related to the open source Rasa framework labels Oct 8, 2020
@indam23 indam23 self-assigned this Oct 8, 2020
@indam23 indam23 added this to the 2.1 Rasa Open Source milestone Oct 8, 2020
@rgstephens
Copy link
Contributor

Here's a similar issue with responses. button_type is not valid at this location, but validate and train don't throw an error.

  utter_ask_feedback:
  - buttons:
    - button_type: inline
    - payload: /feedback{"feedback_value":"positive"}
      title: 👍
    - payload: /feedback{"feedback_value":"negative"}
      title: 👎
    text: How is this conversation going?

@indam23
Copy link
Contributor Author

indam23 commented Oct 9, 2020

The trouble with responses is depending on the channel, those keys may be valid or not. With built in classifiers, the possible keys are known.

@wochinge
Copy link
Contributor

would be great to find a general solution which also works for other NLU components than classifiers

@indam23
Copy link
Contributor Author

indam23 commented Oct 27, 2020

@wochinge one way would be if each component class had an options or settings property that was a list of legitimate keys for that component. Then it could be validated like the name property is validated. wdyt?

@wochinge
Copy link
Contributor

The defaults should already give us that information 🤔

@indam23
Copy link
Contributor Author

indam23 commented Oct 28, 2020

Do all possible options have defaults?

@indam23
Copy link
Contributor Author

indam23 commented Oct 29, 2020

looks like it. I'll use that then

@wochinge
Copy link
Contributor

wait - so you're working on this?

@indam23
Copy link
Contributor Author

indam23 commented Oct 29, 2020

I'm about to unless someone else started already?

@wochinge
Copy link
Contributor

Fine for me - it's just for the 2.1 release plan 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:rasa-oss 🎡 Anything related to the open source Rasa framework type:bug 🐛 Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants