Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Slack Connector for new Events API #6986

Merged
merged 11 commits into from
Oct 15, 2020
Merged

Conversation

b-quachtran
Copy link
Contributor

@b-quachtran b-quachtran commented Oct 9, 2020

Proposed changes:

  • Updated Slack Connector for new Events API format documented here

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@b-quachtran b-quachtran linked an issue Oct 9, 2020 that may be closed by this pull request
@b-quachtran b-quachtran marked this pull request as ready for review October 12, 2020 19:42
@anuragdtnomy
Copy link

Slack : Bot doesnt respond at all : "TypeError: 'NoneType' object is not iterable". trace =>line 203, in _sanitize_user_message , for uid_to_remove in uids_to_remove: #6895

@rasabot rasabot merged commit 2f2b57e into master Oct 15, 2020
@rasabot rasabot deleted the slack_events_api_fix branch October 15, 2020 19:40
erohmensing pushed a commit that referenced this pull request Oct 16, 2020
Updated Slack Connector for new Events API
@erohmensing
Copy link
Contributor

@b-quachtran should we port this to 2.0.x?

@b-quachtran
Copy link
Contributor Author

@erohmensing Yep, I'm on it, it shouldn't be too much effort from this PR

@gauravbgh
Copy link

any update?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants