Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix whitespace LM tokenize issue #7407

Merged
merged 25 commits into from
Dec 14, 2020

Conversation

howl-anderson
Copy link
Contributor

Proposed changes:

  • Skip token when its text can't be tokenized by LM tokenizer (for example, whitespace)

fixs #7406

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@sara-tagger
Copy link
Collaborator

Thanks for submitting a pull request 🚀 @rctatman will take a look at it as soon as possible ✨

@sara-tagger sara-tagger requested a review from rctatman December 1, 2020 08:51
@tmbo tmbo removed the request for review from rctatman December 7, 2020 10:20
Copy link
Member

@tmbo tmbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good 👍 can you please add a test to the unit tests in tests/nlu/featurizers/test_lm_featurizer.py as well as a changelog file to changelog/?

@howl-anderson
Copy link
Contributor Author

@tmbo Sure! I will add those features in later commits.

@howl-anderson
Copy link
Contributor Author

@tmbo Please take a look

Copy link
Member

@tmbo tmbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks a lot for this whitespace fix - really cool 🚀

changelog/7407.bugfix.md Outdated Show resolved Hide resolved
@rasabot
Copy link
Collaborator

rasabot commented Dec 14, 2020

Could not update branch. Most likely this is due to a merge conflict. Please update the branch manually and fix any issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants