-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix whitespace LM tokenize issue #7407
fix whitespace LM tokenize issue #7407
Conversation
Thanks for submitting a pull request 🚀 @rctatman will take a look at it as soon as possible ✨ |
…hitespace_lm_tokenize_issue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good 👍 can you please add a test to the unit tests in tests/nlu/featurizers/test_lm_featurizer.py as well as a changelog file to changelog/?
@tmbo Sure! I will add those features in later commits. |
@tmbo Please take a look |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks a lot for this whitespace fix - really cool 🚀
Could not update branch. Most likely this is due to a merge conflict. Please update the branch manually and fix any issues. |
Proposed changes:
fixs #7406
Status (please check what you already did):
black
(please check Readme for instructions)