#7329 load models in finetune mode core #7458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dakshvar22
requested changes
Dec 7, 2020
wochinge
reviewed
Dec 7, 2020
dakshvar22
reviewed
Dec 7, 2020
wochinge
reviewed
Dec 8, 2020
…oad_models_in_finetune_mode_core
dakshvar22
approved these changes
Dec 8, 2020
Comment on lines
+503
to
+506
| meta["should_finetune"] = kwargs.get("should_finetune", False) | ||
| if "epoch_override" in kwargs: | ||
| meta[EPOCHS] = kwargs["epoch_override"] | ||
|
|
There was a problem hiding this comment.
This needs a larger change which i'll address in my PR as part of making core policies finetunable. It's okay to keep as it is here.
Co-authored-by: Daksh Varshneya <d.varshneya@rasa.com>
Co-authored-by: Tobias Wochinger <t.wochinger@rasa.com>
|
@joejuzl Can you add the required changes to custom policies in the migration guide as part of this PR itself? |
|
I think a constant for |
|
@dakshvar22 I think a separate PR for the migration guide would make more sense so we can start using this code easier in other PRs. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes:
Load the core models in fine-tuning mode.
Status (please check what you already did):
black(please check Readme for instructions)