Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

External Message Entity Auto-Filling Fix #7722

Merged
merged 3 commits into from
Jan 14, 2021
Merged

External Message Entity Auto-Filling Fix #7722

merged 3 commits into from
Jan 14, 2021

Conversation

b-quachtran
Copy link
Contributor

@b-quachtran b-quachtran commented Jan 13, 2021 •
edited
Loading

External Message Entity Auto-Filling Fix

Proposed changes:

  • Fixed external message's tracker update call to enable slot-autofilling when an entity is passed in via the trigger_intent API endpoint

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

federicotdn
federicotdn approved these changes Jan 14, 2021
View reviewed changes
Copy link
Contributor

@federicotdn federicotdn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That works 👍

@b-quachtran b-quachtran merged commit 70e652a into 1.10.x Jan 14, 2021
@b-quachtran b-quachtran deleted the external_message_autofill_fix branch January 14, 2021 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@federicotdn federicotdn federicotdn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@b-quachtran @federicotdn