Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

invert dialogue time in ted #7867

Merged
merged 14 commits into from
Feb 5, 2021
Merged

invert dialogue time in ted #7867

merged 14 commits into from
Feb 5, 2021

Conversation

Ghostvv
Copy link
Contributor

@Ghostvv Ghostvv commented Feb 2, 2021

Proposed changes:

Some results on Sara:
main -> conv acc 0.533, action acc 0.841
mcfly-ted -> conv acc 0.564, action acc 0.873

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

Copy link
Contributor

@dakshvar22 dakshvar22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small refactor comments. Also, since you posted some results on slack, just for the sake of record can you post the results of the experiment in the PR description too?

changelog/7867.improvement.md Outdated Show resolved Hide resolved
rasa/core/policies/ted_policy.py Show resolved Hide resolved
rasa/core/policies/ted_policy.py Outdated Show resolved Hide resolved
Ghostvv and others added 3 commits February 4, 2021 11:49
Co-authored-by: Daksh Varshneya <d.varshneya@rasa.com>
@Ghostvv Ghostvv requested a review from dakshvar22 February 4, 2021 14:36
changelog/7867.bugfix.md Outdated Show resolved Hide resolved
Co-authored-by: Daksh Varshneya <d.varshneya@rasa.com>
@rasabot rasabot merged commit 3338ab3 into main Feb 5, 2021
@rasabot rasabot deleted the mcfly-ted branch February 5, 2021 11:03
samsucik added a commit that referenced this pull request Feb 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants