Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Locking Mechanism to Reminders Handler #8001

Merged
merged 5 commits into from
Feb 25, 2021
Merged

Added Locking Mechanism to Reminders Handler #8001

merged 5 commits into from
Feb 25, 2021

Conversation

b-quachtran
Copy link
Contributor

@b-quachtran b-quachtran commented Feb 19, 2021 •
edited
Loading

Proposed changes:

  • Added lock_store as an input to MessageProcessor so that handle_reminder can properly lock the conversation
  • Updated handle_reminder to lock the conversation before retrieving the tracker store & executing
  • Updated default_processor to pass in InMemoryLockStore as a param for test cases
  • Resolves Issue Reminder Events Don't Acquire a Conversation Lock #7887

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@b-quachtran b-quachtran requested a review from alwx February 19, 2021 22:50
@b-quachtran b-quachtran removed the request for review from alwx February 23, 2021 19:00
@b-quachtran
Copy link
Contributor Author

b-quachtran commented Feb 24, 2021 •
edited by desmarchris
Loading

@akelad Would you have time to review the PR this week / do you know anyone who would have time to look at this? This is for a customer

alwx
alwx approved these changes Feb 25, 2021
View reviewed changes
Copy link
Contributor

@alwx alwx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for me. Thanks for taking care of that!

@akelad
Copy link
Contributor

akelad commented Feb 25, 2021

wow a review with no comments 😱

@akelad akelad merged commit 3fb8f13 into 2.3.x Feb 25, 2021
@akelad akelad deleted the reminders-lock-fix-2-X branch February 25, 2021 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alwx alwx alwx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@b-quachtran @akelad @alwx