Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing space before timezone #73

Open
jamesmyatt opened this issue Dec 4, 2020 · 5 comments
Open

Missing space before timezone #73

jamesmyatt opened this issue Dec 4, 2020 · 5 comments

Comments

@jamesmyatt
Copy link
Contributor

From the example:

In [7]:
%watermark -u -n -t -z

Out[7]:
Last updated: Fri Nov 20 2020 15:27:00UTC

Should be a space before "UTC".

@rasbt
Copy link
Owner

rasbt commented Dec 4, 2020

I think you are right! I think the UTC format itself doesn't use a space but for "UTC" in the string, there should be a space:

Screen Shot 2020-12-04 at 9 15 52 AM

Source: https://www.utctime.net

@jamesmyatt
Copy link
Contributor Author

jamesmyatt commented Dec 5, 2020

I think "Z" is just a special code for "+0000": https://en.wikipedia.org/wiki/ISO_8601#Time_offsets_from_UTC

i.e. the UTC format has a "Z" at the end to indicate that it's UTC

@jamesmyatt
Copy link
Contributor Author

Also, I think that https://www.utctime.net/ is right that there ought to be a comma after the weekday too. And also, international format is always day-month-year or year-month-day.

Finally, I think US format would require a comma between the day and year too.

@jamesmyatt
Copy link
Contributor Author

To be honest, my preference out of all of the options shown on https://www.utctime.net/ for human readability, is RFC1123 (or RSS) best, because it has consistent use of short name and a 4 digit year.

If you're doing to use the long name for the time zone, then why not the long name for the weekday and the month too? Plus 4 digit years are mandatory in a post-y2k age.

@rasbt
Copy link
Owner

rasbt commented Dec 5, 2020

To be honest, originally I made this without being aware of the different time zone formats, which is why it's no particular one. I like the RFC1123 best as well. It contains all the info in a readable order.

PS: There is a separate watermark option for the ISO format (-i, --iso8601). I think it is a good format for parsing purposes but not that readable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants