Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid crash when no data is returned from query #11

Open
ghost opened this issue Jul 22, 2021 · 0 comments
Open

Avoid crash when no data is returned from query #11

ghost opened this issue Jul 22, 2021 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@ghost
Copy link

ghost commented Jul 22, 2021

In the case where no data is returned, the plugin crashes. Then, when the time range is changed and data is again available, it does not automatically recover. A full page reload is required to clear the error.

image

Expected behavior: when there's no data returned from the query to compute the word cloud, don't attempt to render; just show "No Data" or similar

Actual behavior: JS crash with red !, requiring full page reload to recover

Error message: TypeError: Cannot read property 'fields' of undefined
at eval (/public/plugins/magnesium-wordcloud-panel/module.js:2)
at na (vendorsapp.0cd8deb042c68e8113e4.js:2)
at La (vendors
app.0cd8deb042c68e8113e4.js:2)
at Uu (vendorsapp.0cd8deb042c68e8113e4.js:2)
at ks (vendors
app.0cd8deb042c68e8113e4.js:2)
at ws (vendorsapp.0cd8deb042c68e8113e4.js:2)
at _s (vendors
app.0cd8deb042c68e8113e4.js:2)
at ds (vendorsapp.0cd8deb042c68e8113e4.js:2)
at vendors
app.0cd8deb042c68e8113e4.js:2
at t.unstable_runWithPriority (vendors~app.0cd8deb042c68e8113e4.js:2)
ou @ react-dom.production.min.js:216
getDiagramSeriesModel.tsx:134

Browser: Chrome 92
OS: MacOS 11.3.1

@raulsperoni raulsperoni added the bug Something isn't working label Jul 22, 2021
@raulsperoni raulsperoni self-assigned this Jul 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant