Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(terminal): fix password dialog on terminal page #198

Merged
merged 2 commits into from
Apr 3, 2022
Merged

fix(terminal): fix password dialog on terminal page #198

merged 2 commits into from
Apr 3, 2022

Conversation

ravenclaw900
Copy link
Owner

@ravenclaw900 ravenclaw900 commented Apr 1, 2022 •
edited
Loading

  • Test with password
  • Test without password
  • Test with other nodes (1 with password, 1 without)
  • Test with other nodes (2 with password)
  • Test with other nodes (2 without password)

@ravenclaw900 ravenclaw900 added the bug Something isn't working label Apr 1, 2022
@ravenclaw900 ravenclaw900 requested a review from MichaIng April 1, 2022 01:21
@ravenclaw900 ravenclaw900 mentioned this pull request Apr 1, 2022
Open
24 tasks
@ravenclaw900
Copy link
Owner Author

ravenclaw900 commented Apr 2, 2022 •
edited
Loading

@MichaIng, please test and review. Shouldn't mess anything else up, with what's changed, but you can't be too careful.

@ravenclaw900 ravenclaw900 enabled auto-merge (squash) April 2, 2022 15:25
@ravenclaw900 ravenclaw900 disabled auto-merge April 3, 2022 14:38
@ravenclaw900 ravenclaw900 merged commit 807f954 into main Apr 3, 2022
@ravenclaw900 ravenclaw900 deleted the password-terminal branch April 3, 2022 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaIng MichaIng Awaiting requested review from MichaIng

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ravenclaw900