New anchored filter method #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruliana
force-pushed
the
anchored-filter-method
branch
from
857db14
to
c4a720d
Compare
raxod502
reviewed
Oct 6, 2020
There was a problem hiding this comment.
Seems good to me! Thank you for helping out :)
Just add a changelog entry and I'll be happy to merge.
Should I squash the commits? (Assuming "yes", but it's better to ask) 😬 |
"Anchored" uses uppercase letters and symbols as anchors for word beginning. For example, assuming the text "find-file-at-point": - Query "FFP" matches "(find)-(file)-at-(point)" - Query "FiPoint" matches "(find)-file-at-(point)" - Query "fiFAP" matches "(find)-(file)-(at)-(point)" - Query "fi-a-p" matches "(find)-file-(at)-(point)" The rationale for a new filter is that it has the convenience of "initialism", with more control, but without increase the number of keystrokes.
ruliana
force-pushed
the
anchored-filter-method
branch
from
14741af
to
c117a0e
Compare
|
All changes done 🙂 |
|
Whether you squash or not is up to you. GitHub lets me do that automatically when I merge the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New
anchoredfilter methodThe proposed filter uses uppercased letters and symbols as anchors
for word beginning.
For example, assuming the text "find-file-at-point":
The rationale for a new filter is that it has the convenience of
initialism,with more control to the user, but without increase the number of
keystrokes.