Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

selectrum-read-directory-name problems #126

Closed
clemera opened this issue Jul 12, 2020 · 0 comments · Fixed by #127
Closed

selectrum-read-directory-name problems #126

clemera opened this issue Jul 12, 2020 · 0 comments · Fixed by #127

Comments

@clemera
Copy link
Collaborator

clemera commented Jul 12, 2020

To make it more convenient to select the current directory selectrum-read-directory-name changes the default-filename passed to read-file-name-default. This changes the result value in some cases: When you submit the prompt you get this default value as a result which is unexpected.

Another problem is that currently the sorting of the current directory to the top has stopped working because it still assumes directories have trailing slashes while these are now shown with overlays again.

Maybe instead of overriding read-directory-name we could initially select the prompt when reading directory names. This approach would keep the convenience that one can just press RET for the current directory while avoiding any incompatible behaviour changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

1 participant