Update minibuffer height according to text height #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clemera
force-pushed
the
don't-allow-line-spacing-in-minibuffer
branch
from
e8f934c to
1ce6fba
Compare
clemera
changed the title
clemera
changed the title
clemera
force-pushed
the
don't-allow-line-spacing-in-minibuffer
branch
7 times, most recently
from
36c8326 to
04a1c83
Compare
clemera
force-pushed
the
don't-allow-line-spacing-in-minibuffer
branch
2 times, most recently
from
b21042e to
bf5f217
Compare
|
The height issues were already present before #133 so I added it this to the |
clemera
force-pushed
the
don't-allow-line-spacing-in-minibuffer
branch
8 times, most recently
from
e1650f2 to
8352e77
Compare
clemera
force-pushed
the
don't-allow-line-spacing-in-minibuffer
branch
4 times, most recently
from
cfea7ac to
16a8b41
Compare
clemera
force-pushed
the
don't-allow-line-spacing-in-minibuffer
branch
from
16a8b41 to
a073e77
Compare
clemera
force-pushed
the
don't-allow-line-spacing-in-minibuffer
branch
from
7894cea to
97b588b
Compare
clemera
changed the title
This was referenced Aug 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This aims to fix #151 and #146. I also fixed the problem that each minibuffer invocation created a fresh overlay while we should better reuse the old one.