Be more lenient when pressing TAB and nothing matches #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, an error occurs when TAB is pressed and no candidate matches the minibuffer contents. Moreover, the minibuffer contents are erased. This commit makes the behavior more lenient and similar to the default minibuffer completion -- the bell is rung a “No match” message is displayed. Also, ‘completion-fail-discreetly’ is respected so none of the aforementioned things are done if it is non-nil.
|
Very nice, thanks! |
raxod502
added a commit
that referenced
this pull request
Sep 19, 2020
raxod502
reviewed
Sep 19, 2020
| @@ -131,6 +131,10 @@ The format is based on [Keep a Changelog]. | |||
| an error would be thrown ([#152]). | |||
| * When completing filenames and a match is required, non-normalized | |||
| paths (e.g., `~/Documents//etc/hosts`) are accepted ([#190]). | |||
| * Pressing TAB when nothing matches shows a “No match” message in the | |||
| minibuffer instead of signaling an error and erasing the minibuffer | |||
| contents ([#193]). If ‘completion-fail-discreetly’ is non-nil, | |||
There was a problem hiding this comment.
This style of quotes won't render correctly in Markdown, so I updated master to use regular backticks on both sides.
There was a problem hiding this comment.
Thank you, I did not notice those quotes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, an error occurs when TAB is pressed and no candidate
matches the minibuffer contents. Moreover, the minibuffer contents
are erased.
This commit makes the behavior more lenient and similar to the default
minibuffer completion -- the bell is rung a “No match” message is
displayed. Also, ‘completion-fail-discreetly’ is respected so none of
the aforementioned things are done if it is non-nil.