Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Respect predicate passed to `selectrum-read-buffer' (fix #32) #33

Merged
merged 6 commits into from
Apr 7, 2020
Merged

Respect predicate passed to `selectrum-read-buffer' (fix #32) #33

merged 6 commits into from
Apr 7, 2020

Conversation

clemera
Copy link
Collaborator

@clemera clemera commented Mar 24, 2020

No description provided.

raxod502
raxod502 requested changes Mar 25, 2020
View reviewed changes
selectrum.el Outdated Show resolved Hide resolved
@raxod502 raxod502 added the waiting on response Needs more info or follow-up, will be closed after 90 days if no response label Mar 25, 2020
@raxod502 raxod502 mentioned this pull request Mar 25, 2020
Closed
raxod502
raxod502 reviewed Mar 26, 2020
View reviewed changes
Copy link
Member

@raxod502 raxod502 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me, just needs an entry in the changelog noting the bugfix (no need to mention in the README as this isn't user-visible).

@clemera
Copy link
Collaborator Author

clemera commented Mar 26, 2020

Done

raxod502
raxod502 approved these changes Apr 7, 2020
View reviewed changes
Copy link
Member

@raxod502 raxod502 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thank you for your patience.

@raxod502 raxod502 merged commit 43e96c3 into radian-software:master Apr 7, 2020
@raxod502 raxod502 removed the waiting on response Needs more info or follow-up, will be closed after 90 days if no response label Dec 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raxod502 raxod502 raxod502 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@clemera @raxod502