Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve history handling #57

Merged
merged 2 commits into from
Apr 18, 2020
Merged

Improve history handling #57

merged 2 commits into from
Apr 18, 2020

Conversation

clemera
Copy link
Collaborator

@clemera clemera commented Apr 18, 2020

No description provided.

@clemera clemera mentioned this pull request Apr 18, 2020
Merged
@clemera clemera changed the title Cleanup history var usage Improve history handling Apr 18, 2020
@clemera
Copy link
Collaborator Author

clemera commented Apr 18, 2020 •
edited
Loading

Binding minibuffer-history-variable no longer necessary as the hook runs inside read-from-minibuffer now. Narrowing is not needed for the history commands, in addition to that M-r threw an read only error so it also needs a remapping which fixes that. Also now point is kept consistently at beginning of input for all history commands.

raxod502
raxod502 approved these changes Apr 18, 2020
View reviewed changes
Copy link
Member

@raxod502 raxod502 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. This fixes bugs in features that were introduced since the last release, so no need to note in the changelog.

@raxod502 raxod502 merged commit 957289f into radian-software:master Apr 18, 2020
@clemera clemera mentioned this pull request Apr 29, 2020
Merged
@clemera clemera mentioned this pull request Jan 5, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raxod502 raxod502 raxod502 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@clemera @raxod502