Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Automatically expire GCS FT Redis keys #959

Open
1 of 2 tasks
Tracked by #1033
JoshKarpel opened this issue Mar 14, 2023 · 1 comment
Open
1 of 2 tasks
Tracked by #1033

[Feature] Automatically expire GCS FT Redis keys #959

JoshKarpel opened this issue Mar 14, 2023 · 1 comment
Labels
enhancement New feature or request gcs ft P1 Issue that should be fixed within a few weeks

Comments

@JoshKarpel
Copy link
Contributor

Search before asking

  • I had searched in the issues and found no similar feature requirement.

Description

Context: https://ray-distributed.slack.com/archives/C02GFQ82JPM/p1678805965595599?thread_ts=1677186556.706449&cid=C02GFQ82JPM

If someone is using Redis for GCS FT, the key(s) used by their Ray clusters will currently pile up forever. The user is responsible for removing the keys, either by knowing their names and removing them/setting expirations themselves, or by configuring the Redis cluster to use a key eviction policy, neither of which might be desirable depending on the user's particular needs.

The suggested feature is that Ray/KubeRay should manage the expiration/cleanup of its own GCS FT keys, possibly by setting (and refreshing as needed) expiration times on them, or by whatever mechanism is appropriate.

Use case

I work with a Redis cluster for FT that we can't set to evict keys, and I want to make sure I don't fill it up with old Ray GCS information.

Related issues

No response

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!
@JoshKarpel JoshKarpel added the enhancement New feature or request label Mar 14, 2023
@JoshKarpel JoshKarpel changed the title [Feature] Automatically expire GCS FT Redis key(s) [Feature] Automatically expire GCS FT Redis keys Mar 14, 2023
@Jeffwan
Copy link
Collaborator

Jeffwan commented Mar 15, 2023

/cc @wilsonwang371

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request gcs ft P1 Issue that should be fixed within a few weeks
Projects
None yet
Development

No branches or pull requests

3 participants