From 5a6c33536df3f6ed5e987a169b82739bb7e3d80e Mon Sep 17 00:00:00 2001 From: Lonnie Liu <95255098+aslonnie@users.noreply.github.com> Date: Tue, 5 Nov 2024 11:44:23 -0800 Subject: [PATCH] cherrypick #48563 and #48527 (#48574) fixes rllib release tests and mac debugger test Signed-off-by: Lonnie Liu --- python/ray/tests/test_ray_debugger.py | 9 +++++++++ release/ml_user_tests/tune_rllib/run_connect_tests.py | 10 +++++++--- 2 files changed, 16 insertions(+), 3 deletions(-) diff --git a/python/ray/tests/test_ray_debugger.py b/python/ray/tests/test_ray_debugger.py index ea3639f10c6f..4bc5a25930a5 100644 --- a/python/ray/tests/test_ray_debugger.py +++ b/python/ray/tests/test_ray_debugger.py @@ -149,6 +149,15 @@ def fact(n): result = fact.remote(5) + wait_for_condition( + lambda: len( + ray.experimental.internal_kv._internal_kv_list( + "RAY_PDB_", namespace=ray_constants.KV_NAMESPACE_PDB + ) + ) + > 0 + ) + p = pexpect.spawn("ray debug") p.expect("Enter breakpoint index or press enter to refresh: ") p.sendline("0") diff --git a/release/ml_user_tests/tune_rllib/run_connect_tests.py b/release/ml_user_tests/tune_rllib/run_connect_tests.py index 7fb4b2e73ccb..8c9230044adb 100644 --- a/release/ml_user_tests/tune_rllib/run_connect_tests.py +++ b/release/ml_user_tests/tune_rllib/run_connect_tests.py @@ -26,16 +26,20 @@ def run(smoke_test=False, storage_path: str = None): config = ( APPOConfig() + .api_stack( + enable_rl_module_and_learner=False, + enable_env_runner_and_connector_v2=False, + ) .environment("ale_py:ALE/Pong-v5", clip_rewards=True) .framework(tune.grid_search(["tf", "torch"])) .rollouts( rollout_fragment_length=50, - num_rollout_workers=num_workers, - num_envs_per_worker=1, + num_env_runners=num_workers, + num_envs_per_env_runner=1, ) .training( train_batch_size=750, - num_sgd_iter=2, + num_epochs=2, vf_loss_coeff=1.0, clip_param=0.3, grad_clip=10,