Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn compiler warnings into errors. #1087

Closed
robertnishihara opened this issue Oct 5, 2017 · 1 comment
Closed

Turn compiler warnings into errors. #1087

robertnishihara opened this issue Oct 5, 2017 · 1 comment

Comments

@robertnishihara
Copy link
Collaborator

Given problems that people are running into on nonstandard platforms such as #1008, we should make sure to get rid of all compiler warnings and cause them to fail the build. That will help catch bugs. We should also be strict about using static_cast and things like that.

@robertnishihara
Copy link
Collaborator Author

Some of this is done in #1116. We should probably also compile with -Wextra and -pedantic (see the discussion in #1116), but those add a lot of errors, and we'd need to exclude checking of the UT files and the redis code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants