Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Serve] Getting Started doc: Converting to a Ray Serve deployment: Various issues #34481

Closed
angelinalg opened this issue Apr 17, 2023 · 2 comments
Assignees
Labels
docs An issue or change related to documentation P1 Issue that should be fixed within a few weeks serve Ray Serve Related Issue

Comments

@angelinalg
Copy link
Contributor

angelinalg commented Apr 17, 2023

Description

  1. The code example in the Converting-to-a-ray-serve-deployment section has line numbers. If you use the copy and paste button, it includes the line numbers and the user needs to remove them. Is there a particular reason for including line numbers for this example?

  2. Suggest spelling out the python serve_deployment.py command.

  3. Getting these errors: (ServeReplica:Translator pid=13568) 2023-04-17 11:42:32.206766: W tensorflow/stream_executor/platform/default/dso_loader.cc:64] Could not load dynamic library 'libcuda.so.1'; dlerror: libcuda.so.1: cannot open shared object file: No such file or directory; LD_LIBRARY_PATH: /usr/local/nvidia/lib:/usr/local/nvidia/lib64 (ServeReplica:Translator pid=13568) 2023-04-17 11:42:32.206800: W tensorflow/stream_executor/cuda/cuda_driver.cc:269] failed call to cuInit: UNKNOWN ERROR (303) (ServeReplica:Translator pid=13567) 2023-04-17 11:42:32.207429: W tensorflow/stream_executor/platform/default/dso_loader.cc:64] Could not load dynamic library 'libcuda.so.1'; dlerror: libcuda.so.1: cannot open shared object file: No such file or directory; LD_LIBRARY_PATH: /usr/local/nvidia/lib:/usr/local/nvidia/lib64 (ServeReplica:Translator pid=13567) 2023-04-17 11:42:32.207464: W tensorflow/stream_executor/cuda/cuda_driver.cc:269] failed call to cuInit: UNKNOWN ERROR (303)

  4. Add guidance on what to expect after the last step. Should the reader just get the message that says, Deployed Serve app successfully?

  5. Is this a typo? python model.py -> python summary_model.py

Link

https://docs.ray.io/en/latest/serve/getting_started.html#converting-to-a-ray-serve-deployment

@angelinalg angelinalg added P1 Issue that should be fixed within a few weeks serve Ray Serve Related Issue docs An issue or change related to documentation labels Apr 17, 2023
@angelinalg angelinalg changed the title [Serve] Getting Started doc: Copy and paste translator code includes line numbers [Serve] Getting Started doc: Converting to a Ray Serve deployment: Various issues Apr 17, 2023
@angelinalg
Copy link
Contributor Author

cc: @akshay-anyscale

@angelinalg
Copy link
Contributor Author

This PR (34617) fixes #1 and #2 but not the rest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs An issue or change related to documentation P1 Issue that should be fixed within a few weeks serve Ray Serve Related Issue
Projects
None yet
Development

No branches or pull requests

2 participants