Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unreachable code in ray project #36021

Closed
ollie-iterators opened this issue Jun 2, 2023 · 0 comments · Fixed by #36599
Closed

Unreachable code in ray project #36021

ollie-iterators opened this issue Jun 2, 2023 · 0 comments · Fixed by #36599
Assignees
Labels
bug Something that is supposed to be working; but isn't P1 Issue that should be fixed within a few weeks

Comments

@ollie-iterators
Copy link

What happened + What you expected to happen

There is some code that is unreachable in the ray project.

It is at:

  • "python\ray\actor.py" on line 1408
  • "python\ray\tests\test_streaming_generator.py" at line 637
  • "python\ray\tests\test_streaming_generator.py" at line 633
  • "python\ray\tests\test_streaming_generator.py" at line 94
  • "python\ray\serve\tests\test_streaming_response.py" at line 225
  • "python\ray\serve\tests\test_streaming_response.py" at line 220

Versions / Dependencies

Main branch

Reproduction script

Look at the files that I mentioned.

Issue Severity

Low: It annoys or frustrates me.

@ollie-iterators ollie-iterators added bug Something that is supposed to be working; but isn't triage Needs triage (eg: priority, bug/not-bug, and owning component) labels Jun 2, 2023
@sihanwang41 sihanwang41 added P1 Issue that should be fixed within a few weeks and removed triage Needs triage (eg: priority, bug/not-bug, and owning component) labels Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something that is supposed to be working; but isn't P1 Issue that should be fixed within a few weeks
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants