Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[jobs] test_backwards_compatibility.py is consistently failing on master #37096

Closed
edoakes opened this issue Jul 5, 2023 · 3 comments
Closed

[jobs] test_backwards_compatibility.py is consistently failing on master #37096

edoakes opened this issue Jul 5, 2023 · 3 comments
Assignees
@architkulkarni @edoakes
Labels
bug Something that is supposed to be working; but isn't jobs P0 Issues that should be fixed in short order

Comments

@edoakes
Copy link
Contributor

edoakes commented Jul 5, 2023

Example run:
https://buildkite.com/ray-project/oss-ci-build-branch/builds/4813#01891f7c-3030-451d-b103-c252722fdc06/3368-5113

There appears to be some kind of issue with pydantic versioning causing submitted jobs to fail:

2023-07-04 06:20:26,050	INFO cli.py:56 -- Status message: Failed to start job supervisor: module 'pydantic.fields' has no attribute 'ModelField'.
@edoakes edoakes added bug Something that is supposed to be working; but isn't P0 Issues that should be fixed in short order jobs labels Jul 5, 2023
@edoakes
Copy link
Contributor Author

edoakes commented Jul 5, 2023

@architkulkarni I'm not familiar with this test, could you help take a look please?

@edoakes
Copy link
Contributor Author

edoakes commented Jul 5, 2023

Actually, it looks like it's the same issue as #36990

Fix here: #37097 🤞

@edoakes
Copy link
Contributor Author

edoakes commented Jul 5, 2023

Closed by #37097

@edoakes edoakes closed this as completed Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@architkulkarni architkulkarni

@edoakes edoakes

Labels
bug Something that is supposed to be working; but isn't jobs P0 Issues that should be fixed in short order
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@architkulkarni @edoakes