Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ray Core] "/tmp/ray" should not be hard coded for dashboard/observation. #41648

Closed
luxunxiansheng opened this issue Dec 5, 2023 · 5 comments · Fixed by #47871
Closed

[Ray Core] "/tmp/ray" should not be hard coded for dashboard/observation. #41648

luxunxiansheng opened this issue Dec 5, 2023 · 5 comments · Fixed by #47871
Assignees
Labels
bug Something that is supposed to be working; but isn't core Issues that should be addressed in Ray Core @external-author-action-required Alternate tag for PRs where the author doesn't have labeling permission. observability Issues related to the Ray Dashboard, Logging, Metrics, Tracing, and/or Profiling size:small usability

Comments

@luxunxiansheng
Copy link

What happened + What you expected to happen

When I config the --temp-dir for the ray start , the output does redirect to the new folder. However, the generated artifacts found in the /session/latest/metrics/ are still using the "/tmp/ray " . Ideally all the places once using "/tmp/ray" should be replaced with the new temp-dir.

Versions / Dependencies

ray 2.8

Reproduction script

As described above.

Issue Severity

Medium: It is a significant difficulty but I can work around it.

@luxunxiansheng luxunxiansheng added bug Something that is supposed to be working; but isn't triage Needs triage (eg: priority, bug/not-bug, and owning component) labels Dec 5, 2023
@scottsun94 scottsun94 added core Issues that should be addressed in Ray Core P1 Issue that should be fixed within a few weeks observability Issues related to the Ray Dashboard, Logging, Metrics, Tracing, and/or Profiling and removed triage Needs triage (eg: priority, bug/not-bug, and owning component) labels Dec 6, 2023
@scottsun94
Copy link
Contributor

@rkooo567 @rickyyx how hard is it fix this one?

@rkooo567
Copy link
Contributor

rkooo567 commented Dec 6, 2023

I think 1~2 days of work... But the team is very overloaded lately.

@luxunxiansheng Would you be interested in contribution here?

@anyscalesam anyscalesam added p0.5 and removed P1 Issue that should be fixed within a few weeks labels May 10, 2024
@MengjinYan MengjinYan self-assigned this Sep 19, 2024
@MengjinYan
Copy link
Collaborator

@scottsun94 Thanks for reporting the issue!

We tried with a local ray cluster setup with --temp-dir set. At the same time, we setup the local Grafana & Prometheus and execute some jobs on the local setup as well. Unfortunately, from what we see, all the files/artifacts are created under the new folder we specified in --temp-dir and we were not able to reproduce the issue you mentioned.

I'm wondering if you can help provide more detailed steps to reproduce the issue you are facing? It will be very help for our further investigation!!

Also, one thing to note is that, when starting the ray cluster, the default grafana/prometheus configs are generated with /tmp/ray as the base directory. You might need to update the paths before setup the services.

@MengjinYan MengjinYan added the @external-author-action-required Alternate tag for PRs where the author doesn't have labeling permission. label Sep 25, 2024
@scottsun94
Copy link
Contributor

@scottsun94 Thanks for reporting the issue!

We tried with a local ray cluster setup with --temp-dir set. At the same time, we setup the local Grafana & Prometheus and execute some jobs on the local setup as well. Unfortunately, from what we see, all the files/artifacts are created under the new folder we specified in --temp-dir and we were not able to reproduce the issue you mentioned.

I'm wondering if you can help provide more detailed steps to reproduce the issue you are facing? It will be very help for our further investigation!!

Also, one thing to note is that, when starting the ray cluster, the default grafana/prometheus configs are generated with /tmp/ray as the base directory. You might need to update the paths before setup the services.

  1. I didn't report this issue. @luxunxiansheng did.
  2. I thought that @luxunxiansheng was referring to this "the default grafana/prometheus configs are generated with /tmp/ray as the base directory" in the original issue? Shall we change the generated configs based on --temp-dir?

@MengjinYan
Copy link
Collaborator

Thanks for the clarification, @scottsun94! And sorry for the mistag. I misunderstood the ask. I'll take a further look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something that is supposed to be working; but isn't core Issues that should be addressed in Ray Core @external-author-action-required Alternate tag for PRs where the author doesn't have labeling permission. observability Issues related to the Ray Dashboard, Logging, Metrics, Tracing, and/or Profiling size:small usability
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants