Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI test windows://python/ray/tests:test_actor_state_metrics is consistently_failing #46303

Closed
can-anyscale opened this issue Jun 27, 2024 · 10 comments
Closed

CI test windows://python/ray/tests:test_actor_state_metrics is consistently_failing #46303

can-anyscale opened this issue Jun 27, 2024 · 10 comments
Assignees
@jjyao
Labels
bug Something that is supposed to be working; but isn't ci-test core Issues that should be addressed in Ray Core flaky-tracker Issue created via Flaky Test Tracker https://flaky-tests.ray.io/ ray-test-bot Issues managed by OSS test policy stability triage Needs triage (eg: priority, bug/not-bug, and owning component) weekly-release-blocker Issues that will be blocking Ray weekly releases

Comments

@can-anyscale
Copy link
Collaborator

CI test windows://python/ray/tests:test_actor_state_metrics is consistently_failing. Recent failures:
- https://buildkite.com/ray-project/postmerge/builds/5148#01905a62-1f9a-4657-86a7-8b1a1063853d
- https://buildkite.com/ray-project/postmerge/builds/5148#01905703-3ddd-4489-8781-a0ca6805f0e4
- https://buildkite.com/ray-project/postmerge/builds/4923#019017ca-027e-496e-a02c-1bef1eb85426
- https://buildkite.com/ray-project/postmerge/builds/4923#0190178e-5166-421f-bba3-e95f79e67c86

DataCaseName-windows://python/ray/tests:test_actor_state_metrics-END
Managed by OSS Test Policy
@can-anyscale can-anyscale added bug Something that is supposed to be working; but isn't ci-test core Issues that should be addressed in Ray Core flaky-tracker Issue created via Flaky Test Tracker https://flaky-tests.ray.io/ ray-test-bot Issues managed by OSS test policy stability triage Needs triage (eg: priority, bug/not-bug, and owning component) weekly-release-blocker Issues that will be blocking Ray weekly releases labels Jun 27, 2024
@can-anyscale
Copy link
Collaborator Author

likely by 80594fa

@jjyao
Copy link
Collaborator

jjyao commented Jun 27, 2024

Yes, likely this commit. Although seems it only fails windows not linux or mac? Let me debug it

@can-anyscale
Copy link
Collaborator Author

@jjyao yess only on windows

@can-anyscale
Copy link
Collaborator Author

This test is now considered as flaky because it has been failing on postmerge for too long. Flaky tests do not run on premerge.

@jjyao
Copy link
Collaborator

jjyao commented Jun 27, 2024

I'm debugging, worst case is reverting it.

@can-anyscale
Copy link
Collaborator Author

it's the bot that keep commenting, not really me

@jjyao
Copy link
Collaborator

jjyao commented Jun 28, 2024

Ok, found the bug that's uncovered by my commit. We don't need to revert my PR and I'll put up a fix for the bug.

@jjyao
Copy link
Collaborator

jjyao commented Jun 28, 2024

#46329 is the fix

@can-anyscale
Copy link
Collaborator Author

w00h00, @jjyao can we enable auto-merge to get this in as fast as we can, thankks

@can-anyscale
Copy link
Collaborator Author

Test passed on latest run: https://buildkite.com/ray-project/postmerge/builds/5186#01906078-496a-43a0-aea1-0d0ed4406d2b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jjyao jjyao

Labels
bug Something that is supposed to be working; but isn't ci-test core Issues that should be addressed in Ray Core flaky-tracker Issue created via Flaky Test Tracker https://flaky-tests.ray.io/ ray-test-bot Issues managed by OSS test policy stability triage Needs triage (eg: priority, bug/not-bug, and owning component) weekly-release-blocker Issues that will be blocking Ray weekly releases
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jjyao @can-anyscale