Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core][compiled graphs] Don't require finishing previous executions in the case that Python destructs dagrefs out of order #49782

Closed
dayshah opened this issue Jan 12, 2025 · 0 comments · Fixed by #49818
Assignees
Labels
beta Beta release feture compiled-graphs enhancement Request for new feature and/or capability

Comments

@dayshah
Copy link
Contributor

dayshah commented Jan 12, 2025

Description

With #49781, we fixed the case where the destruction of a later dagref will result in the invalidation of previous dagrefs from previous executions. However, that requires us to wait until all previous executions are finished before we can finish the del call for that dagref.

This can becomes an issue because Python doesn't guarantee the order of destruction so if you have a script like

ref1 = compiled_graph.execute(1)
ref2 = compiled_graph.execute(2)
# both are supposed to be destructed somewhere here

Python could call del on ref2 before ref1 and then we would wait for the first execution to finish even though we're not using the result from either.

This shouldn't be a common case, but something that we should think about solving for if we start seeing it happen more often.

Use case

No response

@dayshah dayshah added enhancement Request for new feature and/or capability triage Needs triage (eg: priority, bug/not-bug, and owning component) compiled-graphs labels Jan 12, 2025
@dayshah dayshah self-assigned this Jan 13, 2025
@dayshah dayshah added beta Beta release feture and removed triage Needs triage (eg: priority, bug/not-bug, and owning component) labels Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta Beta release feture compiled-graphs enhancement Request for new feature and/or capability
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant