Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Split giant ray core C++ targets into small ones(stats) #50588

Open
400Ping opened this issue Feb 14, 2025 · 1 comment · May be fixed by #50595
Open

[core] Split giant ray core C++ targets into small ones(stats) #50588

400Ping opened this issue Feb 14, 2025 · 1 comment · May be fixed by #50595
Assignees
@400Ping
Labels
core Issues that should be addressed in Ray Core dependencies Pull requests that update a dependency file enhancement Request for new feature and/or capability

Comments

@400Ping
Copy link
Contributor

400Ping commented Feb 14, 2025 •
edited
Loading

As of now, ray core uses bazel as build system, which encourages small targets.
Ray core is not following the best practice, which bundles all related files into several giant targets. For more information, check out the master issue

Part of #50586
@400Ping 400Ping mentioned this issue Feb 14, 2025
Open
11 tasks
@dentiny dentiny added the core Issues that should be addressed in Ray Core label Feb 14, 2025
@dentiny
Copy link
Contributor

dentiny commented Feb 14, 2025 •
edited
Loading

Thank you for the help! Looking forward to your PR!

@dentiny dentiny added enhancement Request for new feature and/or capability dependencies Pull requests that update a dependency file labels Feb 14, 2025
@400Ping 400Ping linked a pull request Feb 14, 2025 that will close this issue
Open
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@400Ping 400Ping

Labels
core Issues that should be addressed in Ray Core dependencies Pull requests that update a dependency file enhancement Request for new feature and/or capability
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Core] Split stats_metric into smaller targets to improve build performance 400Ping/ray
2 participants
@dentiny @400Ping