From f7cddd02d6eb018fea6f766a82364d0bfd089e80 Mon Sep 17 00:00:00 2001 From: Ubuntu Date: Thu, 12 Sep 2024 23:41:26 +0000 Subject: [PATCH 1/4] . --- python/ray/dag/compiled_dag_node.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/python/ray/dag/compiled_dag_node.py b/python/ray/dag/compiled_dag_node.py index 27a68595d858..b8a3cb7bf209 100644 --- a/python/ray/dag/compiled_dag_node.py +++ b/python/ray/dag/compiled_dag_node.py @@ -661,7 +661,7 @@ def __init__( # We conservatively set num_shm_buffers to _max_inflight_executions. # It means that the DAG can be underutilized, but it guarantees there's # no false positive timeouts. - num_shm_buffers=self._max_inflight_executions, + num_shm_buffers=1, ) if not isinstance(self._buffer_size_bytes, int) or self._buffer_size_bytes <= 0: raise ValueError( From 4e160e6263939b0b7e07626a121ed96f6ec04a8c Mon Sep 17 00:00:00 2001 From: SangBin Cho Date: Fri, 13 Sep 2024 22:42:51 -0700 Subject: [PATCH 2/4] . --- python/ray/dag/tests/experimental/test_accelerated_dag.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/python/ray/dag/tests/experimental/test_accelerated_dag.py b/python/ray/dag/tests/experimental/test_accelerated_dag.py index f30f39a65e42..37496fd0c5dd 100644 --- a/python/ray/dag/tests/experimental/test_accelerated_dag.py +++ b/python/ray/dag/tests/experimental/test_accelerated_dag.py @@ -1970,6 +1970,9 @@ def test_driver_and_actor_as_readers(ray_start_cluster): dag.experimental_compile() +pytest.skip("Currently buffer size is set to 1 because of regression.") + + @pytest.mark.parametrize("temporary_change_timeout", [1], indirect=True) def test_buffered_inputs(shutdown_only, temporary_change_timeout): ray.init() From 223337a8ad7a19407d8513722d4c7fcb4538c27b Mon Sep 17 00:00:00 2001 From: SangBin Cho Date: Fri, 13 Sep 2024 22:43:20 -0700 Subject: [PATCH 3/4] . --- python/ray/dag/tests/experimental/test_accelerated_dag.py | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/python/ray/dag/tests/experimental/test_accelerated_dag.py b/python/ray/dag/tests/experimental/test_accelerated_dag.py index 37496fd0c5dd..5fad955cad17 100644 --- a/python/ray/dag/tests/experimental/test_accelerated_dag.py +++ b/python/ray/dag/tests/experimental/test_accelerated_dag.py @@ -1970,9 +1970,7 @@ def test_driver_and_actor_as_readers(ray_start_cluster): dag.experimental_compile() -pytest.skip("Currently buffer size is set to 1 because of regression.") - - +@pytest.skip("Currently buffer size is set to 1 because of regression.") @pytest.mark.parametrize("temporary_change_timeout", [1], indirect=True) def test_buffered_inputs(shutdown_only, temporary_change_timeout): ray.init() From ad10b40860a9d9eaef8a452cab442f8b5fc9001a Mon Sep 17 00:00:00 2001 From: SangBin Cho Date: Mon, 16 Sep 2024 08:56:58 -0700 Subject: [PATCH 4/4] fix mistakes --- python/ray/dag/tests/experimental/test_accelerated_dag.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/python/ray/dag/tests/experimental/test_accelerated_dag.py b/python/ray/dag/tests/experimental/test_accelerated_dag.py index 5fad955cad17..50b08550cb25 100644 --- a/python/ray/dag/tests/experimental/test_accelerated_dag.py +++ b/python/ray/dag/tests/experimental/test_accelerated_dag.py @@ -1970,7 +1970,7 @@ def test_driver_and_actor_as_readers(ray_start_cluster): dag.experimental_compile() -@pytest.skip("Currently buffer size is set to 1 because of regression.") +@pytest.mark.skip("Currently buffer size is set to 1 because of regression.") @pytest.mark.parametrize("temporary_change_timeout", [1], indirect=True) def test_buffered_inputs(shutdown_only, temporary_change_timeout): ray.init()