Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flake8 v5 support #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add flake8 v5 support #2

wants to merge 1 commit into from

Conversation

Avasam
Copy link

@Avasam Avasam commented Oct 11, 2022

Fixes #1

@Avasam Avasam changed the title Fixes #1 Add flake8 v5 support Oct 11, 2022
@rayjolt
Copy link
Owner

rayjolt commented Oct 12, 2022

@Avasam Thank you for the issue and PR! Your fix looks good to me. I agree with changing Flake8 to version 3 or greater, as it doesn't look so likely that they will break their plugin interface on major releases. It's much more likely that I forget to update the versions, as happened this time...

Could you change the title of your commit to something more descriptive? When people are browsing the log, it won't be clear what was changed if the title is just "Fixes #2". Something like

Add flake8 v5 support

Fixes #2 

should be fine.

@Avasam
Copy link
Author

Avasam commented Oct 12, 2022

Sure thing. It was done quickly using the Github UI. I've amended the commit to a proper message.
Btw I don't currently have a poetry setup to update poetry.lock .

@Avasam
Copy link
Author

Avasam commented Dec 5, 2022

@rayjolt

@Avasam
Copy link
Author

Avasam commented Jul 8, 2023

Is this good to be merged?

@Avasam
Copy link
Author

Avasam commented Aug 18, 2024

@rayjolt Bump. Since this is one of my oldest still open PRs.
Alternatively I'd understand if you don't wanna maintain this plugin anymore, given the many other alternatives (namely

)
In which case you might wanna mark it as unmaintained / archived.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Flake8 v5
2 participants