Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comparison with Spice #1188

Open
mo8it opened this issue Aug 12, 2024 · 2 comments
Open

Comparison with Spice #1188

mo8it opened this issue Aug 12, 2024 · 2 comments

Comments

@mo8it
Copy link

mo8it commented Aug 12, 2024

See the README in https://github.com/judofyr/spice

Why is the overhead of Rayon that huge? Are there any plans to reduce it?

@cuviper
Copy link
Member

cuviper commented Aug 12, 2024

This micro-benchmark is kind of a worst case for rayon -- maximally splitting into jobs with very little actual work involved in each. Some quick perf analysis shows that we're spending most time between crossbeam deques and our sleep code, which isn't surprising to me.

A possibly nicer implementation of that could use rayon::iter::split, so it can avoid recursing quite so deeply. That is more complicated to write though, and I fear it's still not going to be favorable in the small input case.

We don't have current plans to work on the overhead, but of course I'd love to see any improvements that folks can come up with. I wonder if it would be possible to even rewrite rayon-core internals with that heartbeat scheduling approach.

@cuviper
Copy link
Member

cuviper commented Sep 19, 2024

I just saw this Spice port on HN: https://github.com/dragostis/chili

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants