Fix box blur symmetry & simplify code #3631
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous version of box blur kernel was asymmetrical, because the leftmost and topmost pixels were subtracted from the average values too early, causing the image to offset by GAUSSIAN_BLUR_ITERATIONS pixels after blurring. You can see this at the rightmost and bottommost borders of the image. This commit fixes this bug.
Image is also a bit more blurry now since the blur kernel is now 1 pixel wider.
PS. Perhaps GAUSSIAN_BLUR_ITERATIONS could be a function argument rather than a predefined value?