Fixed loading GLTF animations with 1 frame #3804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I was working on my 3D project I found an issue that single frame animations (like T-Pose) are not loaded. Upon investigating the reason I realised that frame count calculated based on animation length (which is 0 apparently).
Using some basic combinatorics I added 1 at the end of frame count calculations. It is easy to think of a veeeery small animation (like 0.01 second) which still has to have minimum 2 frames. Animations with 0 length should have at least 1.
Also fmax is preventing NaN division result when tend and tstart are both 0.