[raymath] Fix for issue 4454, MatrixDecompose() gave incorrect output for certain scale and rotations
#4461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in combinations of scale and rotation
|
@waveydave Thanks for the review! |
psxdev
pushed a commit
to raylib4Consoles/raylib
that referenced
this pull request
Nov 18, 2024
…in combinations of scale and rotation (raysan5#4461)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For transform matrices with certain ranges of rotation angles and scaling factors,
MatrixDecompose()would give incorrect answers.I narrowed down the issue to where the scaling factors are removed from the cloned transform, before the rotation is extracted: the scale factors needed to be taken into account for extra matrix members.
The models_loading_gltf example still works correctly after this fix.
Further tests and discussion here: #4454