Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better naming of GRPC API #160

Open
mabdh opened this issue Aug 18, 2022 · 0 comments
Open

Better naming of GRPC API #160

mabdh opened this issue Aug 18, 2022 · 0 comments
Labels
documentation Improvements or additions to documentation

Comments

@mabdh
Copy link
Member

mabdh commented Aug 18, 2022

Is your feature request related to a problem? Please describe.
There are some APIs that have Create... naming but it is actually doing Upsert in the repository layer. This could make user of API Confused. We need to make the naming consistent with behaviour.

Describe the solution you'd like
Rename all APIs that do upsert accordingly. Instead of calling it Create..., we call it Upsert...

@mabdh mabdh added the documentation Improvements or additions to documentation label Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Status: 2024
Development

No branches or pull requests

1 participant