Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support connection type as unique identifier along with id #16

Closed
NNcrawler opened this issue Sep 28, 2021 · 2 comments · Fixed by #15
Closed

support connection type as unique identifier along with id #16

NNcrawler opened this issue Sep 28, 2021 · 2 comments · Fixed by #15

Comments

@NNcrawler
Copy link
Member

NNcrawler commented Sep 28, 2021

Problem
Raccoon supports unique websocket connections per user by specifying SERVER_WEBSOCKET_CONN_UNIQ_ID_HEADER configuration. There is a requirement to support connection types that is part of another header. Connection types combined with id will be used to maintain unique connections instead.

Which version was this found?
v0.1.0

Is there any workaround?
An alternative approach is to make user id globally unique.

What is the impact?
The current behavior is still supported. However, if SERVER_WEBSOCKET_CONN_TYPE_HEADER config is provided, Raccoon will use the header value together with id for uniqueness.

Solution

  • Add another configuration to specify connection type header key and use that connection type header value as connection identifier.
  • Add conn_type tags to each sensible metrics.
@NNcrawler NNcrawler linked a pull request Sep 28, 2021 that will close this issue
@ravisuhag
Copy link
Member

ravisuhag commented Sep 28, 2021

@NNcrawler SERVER_WEBSOCKET_CONN_GROUP_HEADER Would this be better instead of TYPE. WDYT?

@NNcrawler
Copy link
Member Author

Ya, that will avoid the confusion.

@ramey ramey closed this as completed in #15 Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants