Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash on Storybook 8 #56

Closed
elisehein opened this issue Mar 20, 2024 · 4 comments · Fixed by #54
Closed

Crash on Storybook 8 #56

elisehein opened this issue Mar 20, 2024 · 4 comments · Fixed by #54
Labels

Comments

@elisehein
Copy link

After upgrading to Storybook 8 (8.0.2), clicking the Playroom tab on a Story crashes the page (nothing shows up). Here are the console errors:

CleanShot 2024-03-20 at 14 34 37@2x

Addon version: 5.0.0

I can't say for sure this is new behaviour for SB8, because I never got this plugin working on SB7 either (my issue was this one).

@julrich
Copy link

julrich commented Apr 10, 2024

Would love to see a fix here, too. Might be able to chip in with development, if needed!

@julrich
Copy link

julrich commented Apr 12, 2024

I have to add, though. After some investigation in our own upgraded SB8, it seems to work on SB for us, see here:
https://64f08cbba622af835d382b4f-xucnzisdfc.chromatic.com/?path=/story/components-button--primary-button

So maybe this is a problem (as you already hinted at) that might have always existed in your case @elisehein?

Copy link

github-actions bot commented Aug 4, 2024

🎉 This issue has been resolved in version 6.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@elisehein
Copy link
Author

I'm still experiencing a crash with storybook-playroom-addon@6.0.0 and storybook v 8.2.5 :(

It's now manifesting differently, the stories themselves won't load either, and I get a memory leak error in the console:

CleanShot 2024-08-07 at 10 33 41@2x

Since others don't seem to be experiencing this, I'll do some more investigating and hopefully open a more relevant issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants