fix(rbmk sh): use env.Stdin rather than os.Stdin #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change is mainly for correctness. Ensure we always use the env.Stdin rather than os.Stdin directly, to avoid surprises when we start composing and executing commands without actually spawning a new process but rather as internally running commands. The only place where we were using os.Stdin directly was the `rbmk sh` subcommand. See also rbmk-project/common#14
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is mainly for correctness. Ensure we always use the env.Stdin rather than os.Stdin directly, to avoid surprises when we start composing and executing commands without actually spawning a new process but rather as internally running commands. The only place where we were using os.Stdin directly was the
rbmk shsubcommand.See also rbmk-project/common#14