Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new markup for support of "srcset-w" #68

Closed
nhoizey opened this issue Oct 30, 2015 · 3 comments · Fixed by #88
Closed

Add new markup for support of "srcset-w" #68

nhoizey opened this issue Oct 30, 2015 · 3 comments · Fixed by #88

Comments

@nhoizey
Copy link

nhoizey commented Oct 30, 2015

Most responsive image needs require only the srcset-w attribute on the <img> tag, <picture> being necessary only for Art Direction:
http://blog.cloudfour.com/dont-use-picture-most-of-the-time/

@btobolaski
Copy link
Contributor

That was very enlightening, thank you. So going on that information, this plugin shouldn't generate <picture> tags at all, since it just generates a series of resized images. My plan is to add the srcset markup option and then depreciate the picture markup.

I have a plan for how I'd like the srcset markup option to work and I'll try it out when I get a chance.

@nhoizey
Copy link
Author

nhoizey commented Oct 30, 2015

I think <picture> is also useful, but only if we can provide several images in our content, which might be difficult, so srcset-w should be the default/example configuration, yes.

It's really great to know you have a plan!

@kaffolder7
Copy link

Hi @btobolaski — curious if you ever took a stab at adding in srcset functionality to this plugin? I couldn't agree more that supporting the picture spec by using srcset markup is the best option right now. I started trying to make the switch myself, but sadly I am not much of a Ruby developer. Care sharing any progress you may have made with this, or even what some of your thoughts were regarding plan/setup?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants