Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to v1.8.1 or later of fastimage #71

Closed
nhoizey opened this issue Dec 23, 2015 · 6 comments · Fixed by #88
Closed

Upgrade to v1.8.1 or later of fastimage #71

nhoizey opened this issue Dec 23, 2015 · 6 comments · Fixed by #88

Comments

@nhoizey
Copy link

nhoizey commented Dec 23, 2015

It seems dependency to '> 1.6.4' of fastimage is blocking upgrade to Jekyll 3 if we use the jekyll-assets plugin because it requires fastimage '> 1.8'.

Current version of fastimage is 1.8.1: https://github.com/sdsykes/fastimage/releases

@envygeeks
Copy link

It's not just FastImage that needs to be updated, but MiniMagick will need to be updated or you won't be able to use our proxied image resizers as we only support 4+, this is stuck on 3.

@nhoizey
Copy link
Author

nhoizey commented Dec 24, 2015

Ok, so I'm doomed… :-/

@stuntbox
Copy link

It seems like this repo hasn't gotten much love for awhile, though I've spotted some furtive attempts to bring it back up to speed. I frankly haven't found anything that comes close to filling this badly-needed gap in our Jekyll site work. What else are folks using these days to fill the image-generation-plus-picture-element gap?

@nhoizey
Copy link
Author

nhoizey commented Dec 24, 2015

There's this other plugin: https://github.com/wildlyinaccurate/jekyll-responsive-image

And also, I have great hopes in Jekyll Assets future: envygeeks/jekyll-assets#172

@Boucherie
Copy link

I forked this gem, changed the pessimistic dependency to an optimistic one (~> to (>=), and linked the gemfile request the the forked repo. Can the same be done for minimagick?

@envygeeks
Copy link

IIRR there was some API change that happened in MiniMagick. It wasn't drastic, it just required a little bit of thought around how you handled some things. It's been a long time since Jekyll Assets upgraded, and a long time since I seen this ticket. If you wanna update it and post the error you get (if any) I'm sure I'll remember what changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants